-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/app global iframe #4899
Fix/app global iframe #4899
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes in this pull request primarily involve updates to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
public/assets/Giveth-Co-Marketing-Slides.pdf
is excluded by!**/*.pdf
📒 Files selected for processing (1)
next.config.js
(2 hunks)
🔇 Additional comments (2)
next.config.js (2)
100-104
: Verify the existence of the PDF file.
The redirect configuration looks correct, but we should ensure the destination PDF file exists.
✅ Verification successful
PDF file exists at the expected location
The destination file public/assets/Giveth-Co-Marketing-Slides.pdf
exists, confirming that the redirect configuration in next.config.js
is valid and will work as intended.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the PDF file exists in the public/assets directory
fd -t f "Giveth-Co-Marketing-Slides.pdf" public/assets/
Length of output: 100
164-172
: Verify integration with app.safe.global.
While the security headers will allow embedding in app.safe.global, it would be good to verify:
- That these are the only headers needed for the integration
- That the integration works as expected in all major browsers
✅ Verification successful
Integration with app.safe.global appears properly configured
The codebase shows consistent and complete Safe integration:
- Security headers in
next.config.js
are properly set for embedding - Safe SDK configuration in
wagmiConfigs.ts
andtransaction.ts
includes the correct domain allowlist - Safe API integration is properly configured in
safe/index.ts
The implementation follows Safe's integration requirements with:
- Proper frame-ancestor CSP header
- Correct X-Frame-Options header
- Appropriate CORS configuration
- Consistent domain allowlist in SDK configurations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any other references to safe.global in the codebase
rg -i "safe\.global" --type js --type ts --type jsx --type tsx
Length of output: 92
Script:
#!/bin/bash
# Check for any other references to safe.global in the codebase, using ripgrep without file type filters
rg -i "safe\.global"
Length of output: 490
Script:
#!/bin/bash
# Let's check the context of these Safe-related configurations
echo "=== wagmiConfigs.ts context ==="
rg -B 5 -A 5 "allowedDomains: \[/app\.safe\.global" src/wagmiConfigs.ts
echo -e "\n=== transaction.ts context ==="
rg -B 5 -A 5 "allowedDomains: \[/app\.safe\.global" src/lib/transaction.ts
echo -e "\n=== safe/index.ts context ==="
rg -B 5 -A 5 "safe-transaction-mainnet\.safe\.global" src/lib/safe/index.ts
Length of output: 1304
@divine-comedian when you find time you can check this preview link inside app.safe and if it ok, that is that ;) |
@kkatusic it's working! |
excellent, need approve :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kkatusic
Summary by CodeRabbit
New Features
/comarketing
to download the Giveth Co-Marketing Slides PDF.Security Enhancements
X-Frame-Options
to allow framing from a specific origin.Content-Security-Policy
to include the new origin in the frame-ancestors directive.Access-Control-Allow-Origin
header to enable CORS for the specified origin.